From bc9aefe27fd1487e21a7554360759f08d5c86153 Mon Sep 17 00:00:00 2001 From: ProbablePrime Date: Tue, 30 Jul 2024 19:51:37 -0700 Subject: [PATCH 1/3] Add strings for FOV Effect setting --- en.json | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/en.json b/en.json index 1dbc829..33afda8 100644 --- a/en.json +++ b/en.json @@ -1730,6 +1730,10 @@ "Settings.DesktopRenderSettings.FieldOfView": "Field of view", "Settings.DesktopRenderSettings.FieldOfView.Description": "Use this to control the field of view (FOV) when in desktop mode. Larger values will give you wider view at the cost of greater distortion on the sides.", + + "Settings.DesktopRenderSettings.FieldOfViewEffects": "Field of view effects", + "Settings.DesktopRenderSettings.FieldOfViewEffects.Description": "When this option is enabled, Resonite will apply effects to your field of view based on your interactions in Resonite. For example, the zooming effect when you sprint in desktop.\n Does NOT include effects found in User Generated Content.", + "Settings.DesktopRenderSettings.VSync": "VSync", "Settings.DesktopRenderSettings.VSync.Description": "When this option is enabled, the framerate will be synced with the refresh rate of your screen. Disabling this can render frames faster, but also cause visible tearing.\n\nThis can be useful when doing performance testing, as it will uncap the update and rendering speed.", "Settings.DesktopRenderSettings.LimitFramerateWhenUnfocused": "Limit framerate when in background", From 71a9a153ee207a88d6512d39868f402e009d3212 Mon Sep 17 00:00:00 2001 From: ProbablePrime Date: Mon, 5 Aug 2024 16:21:44 -0700 Subject: [PATCH 2/3] fixup#: rename --- en.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/en.json b/en.json index 33afda8..3ea3e56 100644 --- a/en.json +++ b/en.json @@ -1731,8 +1731,8 @@ "Settings.DesktopRenderSettings.FieldOfView": "Field of view", "Settings.DesktopRenderSettings.FieldOfView.Description": "Use this to control the field of view (FOV) when in desktop mode. Larger values will give you wider view at the cost of greater distortion on the sides.", - "Settings.DesktopRenderSettings.FieldOfViewEffects": "Field of view effects", - "Settings.DesktopRenderSettings.FieldOfViewEffects.Description": "When this option is enabled, Resonite will apply effects to your field of view based on your interactions in Resonite. For example, the zooming effect when you sprint in desktop.\n Does NOT include effects found in User Generated Content.", + "Settings.DesktopRenderSettings.SprintFieldOfViewZoom": "Zoom FOV when sprinting", + "Settings.DesktopRenderSettings.SprintFieldOfViewZoom.Description": "When this option is enabled, Resonite will zoom your FOV when you are sprinting in Desktop.\nDisable the setting to remove the effect.\nDoes NOT include effects found in User Generated Content.", "Settings.DesktopRenderSettings.VSync": "VSync", "Settings.DesktopRenderSettings.VSync.Description": "When this option is enabled, the framerate will be synced with the refresh rate of your screen. Disabling this can render frames faster, but also cause visible tearing.\n\nThis can be useful when doing performance testing, as it will uncap the update and rendering speed.", From d9b4f298511bdfe6f1d8e6ffe1a72f323e2a3f9b Mon Sep 17 00:00:00 2001 From: ProbablePrime Date: Thu, 8 Aug 2024 15:11:19 -0700 Subject: [PATCH 3/3] add comment about WIP strings --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 9c1089e..dc9b33e 100644 --- a/README.md +++ b/README.md @@ -104,6 +104,7 @@ optional arguments: - **DON'T** correct mistakes in the string keys, only report them. They will be fixed by a script, which will apply the correction to all locales at once. - **DON'T** submit purely machine translated locales. Those often result in odd and confusing results for user interfaces. Using machine translation as basis for manual translation is ok. - **DON'T** Submit strings from PRs that have the "New Strings" label until that PR is merged. The development team may need to update or change these strings as a part of their inclusion and this can cause conflicts. Wait till the PR is merged and THEN work on the new strings. +- **DON'T** Submit strings for features that are not present in the "main" branch yet. Until a set of strings is in main, it is not complete and may need additional work to complete. Adding strings early, leads to extra work, Conflicts and confusion. ## The ICU MessageFormat Syntax for translation strings Resonite uses the ICU MessageFormat Syntax defined by the Unicode organization for its localized strings. This offers high amount of flexibility on how you translate strings and ensures that you can correctly follow the grammar rules of your language, particularly with regards to pluralization (e.g. displaying "1 item" vs "1 items"). This is why it's important to ensure that your language has a pluralizer implemented in our fork of MessageFormat.NET